Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: better support typescript #372

Merged
merged 5 commits into from
May 3, 2024
Merged

refactor: better support typescript #372

merged 5 commits into from
May 3, 2024

Conversation

climba03003
Copy link
Member

Checklist

@climba03003 climba03003 changed the base branch from master to next April 26, 2024 07:08
@climba03003
Copy link
Member Author

Double checked the test is failed even in current master.

@mcollina
Copy link
Member

Can you fix it?

@mcollina
Copy link
Member

mcollina commented May 2, 2024

Tests are fixed on master

@climba03003
Copy link
Member Author

climba03003 commented May 2, 2024

The changes here is lazy check typescript environment only when TypeScript extension is used.
It support more case like --loader ts-node/esm, .mts and .cts.

It may land in main if not using ??=

@mcollina
Copy link
Member

mcollina commented May 2, 2024

Then can you make so? ;)

@climba03003 climba03003 changed the base branch from next to master May 3, 2024 03:23
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@melroy89
Copy link

melroy89 commented Oct 15, 2024

@climba03003 Thank you for this! I know this was already in merged in May, but still I wanted to thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants